Skip to content

Port Inlay hints for name parameters #23375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2025
Merged

Conversation

zielinsky
Copy link
Contributor

@zielinsky zielinsky commented Jun 16, 2025

Add inlay hints for name parameters.

Porting scalameta/metals#7400

@zielinsky zielinsky force-pushed the name-parameters branch 3 times, most recently from d41d2a3 to 5e5a48c Compare June 20, 2025 10:12
@zielinsky zielinsky requested review from tgodzik and Florian3k June 20, 2025 10:13
@zielinsky zielinsky marked this pull request as ready for review June 20, 2025 10:13
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I think we can improve it a bit though.

@zielinsky zielinsky force-pushed the name-parameters branch 3 times, most recently from 5bc21a7 to 22ec3a6 Compare June 24, 2025 12:44
@zielinsky zielinsky requested a review from tgodzik June 24, 2025 12:45
@zielinsky zielinsky requested a review from tgodzik June 25, 2025 07:31
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tgodzik tgodzik merged commit d944b61 into scala:main Jun 25, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants